Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp files creation. #23

Closed
PythonCHB opened this issue Jan 14, 2019 · 1 comment · May be fixed by conda-forge/hrds-feedstock#2
Closed

Temp files creation. #23

PythonCHB opened this issue Jan 14, 2019 · 1 comment · May be fixed by conda-forge/hrds-feedstock#2
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@PythonCHB
Copy link
Contributor

In the TestHRDS class, the teardown removes two "buffer" files. But these are not explicitly created in the tests. I haven't dug into the code, but I assume these are automatically created by the HRDS class. Packages really shouldn't create non-explicit temp files like this -- either the user should explicitly specify where they want the temp files to be created, or they should be created in a temp dir (import tempfile), and ideally automatically deleted by the code.

@jhill1 jhill1 self-assigned this Jan 24, 2019
@jhill1 jhill1 added bug Something isn't working enhancement New feature or request labels Jan 24, 2019
jhill1 added a commit that referenced this issue Apr 9, 2019
Remove buffer files by default and write temp files. Fixes Iss #23
@jhill1
Copy link
Contributor

jhill1 commented Apr 9, 2019

Fixed in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants