-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance update #178
Maintenance update #178
Conversation
After a shower and a good walk I decided to go ahead and do it anyways. I tried to make my commits atomic, so you can also revert individual bits if you like. |
Note that this was run with --ignore-missing-imports.
It looks like github no longer has testing for python3.6, could you remove that from the workflows to see if everything passes? Given its a maintenance update, you could also remove notation of 3.6 support from readme since I believe its past EOL? Thanks for the update, I'll release a new version on pypi once merged. |
Since the original README stated that it tested with PyPy as well, I included pypy3.9 in the strategy matrix. I think it makes sense to test for all supported python versions, I added those. I also removed references to Python 3.6 where they are no longer accurate. |
About publishing to PyPi: I am not sure what strategy you would like to adhere to concerning the typing update. I see the following possibilities:
|
@Drvanon Hello, I believe the CI fails as the setup-python action is too old and cannot install pypy39, can you try using |
Re pypy, I'm fine with essentially having two tiers of supported versions: (1) tested with CI, etc so mainly mainline python and (2) not CI, but best effort compatibility. That said, if the fix is to just use a newer version of actions, that works too! Either way, happy to merge once CI passes. |
This branch bumps some versions:
Then I ran
poetry update
in order to ensure that the poetry.lock file was up to date.Using this configuration I was able to run
poetry install
without running in to issue #176, which makes me expect that that that should be resolved, but maybe I do not understand that well enough. It is either that, or the fact that they merged an update last week.I could run
poetry run pytest --cov=functional
without issues, getting the same coverage as is currently posted on the repository. I am having issues with Travis, which is giving me trouble running the build.The new version of black suggests small changes in the tests files, namely the removal of the u-strings and minor formatting stuff for powers. As far as I can tell this is fine. Pylint also complains about the u-strings and then some formatting which was being done in python 3.6 style (using .format as opposed to f strings). Pylint also suggests to specifying the file format when using open in the tests. I can inlcude these suggestions in the PR if you would like me to, though they are all warning level messages.
I would like to mention that there is still a
travis.sh
file in the project root, however as far as I can tell that is from an outdated version of Travis. Would it make sense to remove it in this in this PR?