-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variables for task and container CPU and memory #65
Conversation
…-protocol-security-github/ according to https://github.com/pre-commit/action" This reverts commit 79021ea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this change, but I have a question about line 233 in ecs.tf: is the for
expression doing anything?
I made 2 small comments.
About the |
} | ||
|
||
variable "container_memory" { | ||
description = "The container memroy size" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just saw this typo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo shows up in 1 more place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You fixed all typos. LGTM!
Ishmael asked that the CPU and memory parameters for the task and container be overridable variables. His team's use case requires a lot more of both to execute successfully.