Use personal token and add error handling #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the ROBOT_MAC_FC_TOKEN set up by the Truss team is not configured in Dependabot secrets, so CI was failing for those jobs. We don't know the login info for the old robot user, so for the time being we can use one of my personal tokens (set to expire in 30 days) while we work on getting a new robot user.
Also adds error handling for the API call to GitHub to get the token used to register runners. I did this because I forgot to configure SSO for my PAT and the script that sets up the runners was failing without a helpful error.
Testing:
I ran the image locally with a valid/invalid token to test the branching logic and error messages in
entrypoint.sh