feat: allow single item code block be put in a single line #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ntjess you may see detailed comparsion here |
Enter-tainer
force-pushed
the
mgt/fold-single-item-code
branch
from
6aa8351
to
26dc8ee
Compare
Enter-tainer
force-pushed
the
mgt/fold-single-item-code
branch
from
26dc8ee
to
eed47bd
Compare
|
Hi @ntjess I just add scoped based checking and only expr-like-if will be put in a single line(if possible). Would you mind look at the diff and comment the current behavior? |
Enter-tainer
commented
Jun 29, 2024
Comment on lines
62
to
+65
| #show raw.where(block: false): it => if it.text.starts-with("<") and it.text.ends-with(">") { | ||
| set text(1.2em) | ||
| doc-style.show-type(it.text.slice(1, -1)) | ||
| } else { | ||
| it | ||
| } | ||
| } else { it } |
There was a problem hiding this comment.
This doesn't look good. I suggest we only try put them in a single line iff both branch of if has exactly one item
| return (node.y, node.x) | ||
| } else { | ||
| panic(message: "Invalid tree direction.") | ||
| } |
There was a problem hiding this comment.
looks like currently else-if pattern is not well recognized. They should be stmt-like-if but not expr-like-if
Comment on lines
4222
to
+4224
| let last-row-size = if rows.len() == 0 { | ||
| auto | ||
| } else { | ||
| rows.last() | ||
| } | ||
| } else { rows.last() } |
There was a problem hiding this comment.
Maybe we should either put the two branch in a single line, or we completely expand them. Current status doesn't look good.
Comment on lines
+437
to
+440
| #let max-if-not-none(a, b) = if a in (none, auto) { b } else if b in ( | ||
| none, | ||
| auto, | ||
| ) { a } else { calc.max(a, b) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #76