Merge pull request #28 from Ensighten/fix_nsone_tests

nsone: fix ns1-go test bugs
Ensighten · Sep 7, 2016 · b10f3c8 · b10f3c8
2 parents 756cd10 + 32f4e65
commit b10f3c8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/builtin/providers/nsone/resource_monitoringjob_test.go b/builtin/providers/nsone/resource_monitoringjob_test.go
@@ -116,10 +116,10 @@ func testAccCheckMonitoringJobDestroy(s *terraform.State) error {
 			continue
 		}
 
-		_, err := client.GetMonitoringJob(rs.Primary.Attributes["id"])
+		mj, err := client.GetMonitoringJob(rs.Primary.Attributes["id"])
 
 		if err == nil {
-			return fmt.Errorf("Record still exists")
+			return fmt.Errorf("Monitoring Job still exists %#v: %#v", err, mj)
 		}
 	}
 

diff --git a/builtin/providers/nsone/resource_record_test.go b/builtin/providers/nsone/resource_record_test.go
@@ -195,7 +195,7 @@ func testAccCheckRecordAttributesUpdated(record *nsone.Record) resource.TestChec
 
 const testAccRecordBasic = `
 resource "nsone_record" "foobar" {
-    zone = "terraform.io"
+    zone = "${nsone_zone.test.zone}"
 		domain = "test.terraform.io"
 	  type = "CNAME"
 		ttl = 60

diff --git a/builtin/providers/nsone/resource_zone_test.go b/builtin/providers/nsone/resource_zone_test.go
@@ -116,10 +116,10 @@ func testAccCheckZoneDestroy(s *terraform.State) error {
 			continue
 		}
 
-		_, err := client.GetZone(rs.Primary.Attributes["zone"])
+		zone, err := client.GetZone(rs.Primary.Attributes["zone"])
 
 		if err == nil {
-			return fmt.Errorf("Record still exists")
+			return fmt.Errorf("Record still exists: %#v: %#v", err, zone)
 		}
 	}