Add navigate to view group action #860
Conversation
assets/schema/ensemble_schema.json
Outdated
| "properties": { | ||
| "navigateViewGroup": { | ||
| "type": "object", | ||
| "description": "Navigate between the screens in the view group", |
There was a problem hiding this comment.
add " (applicable only when inside a ViewGroup)"
lib/framework/view/page_group.dart
Outdated
| @@ -113,6 +126,14 @@ class PageGroupState extends State<PageGroup> with MediaQueryCapability { | |||
|
|
|||
| @override | |||
| Widget build(BuildContext context) { | |||
| return ListenableBuilder( | |||
There was a problem hiding this comment.
This will recreate the entire ViewGroup from scratch - we don't want that. We simply want to switch the Tab to another screen. Please make sure we don't rebuild items unnecessary. Optimization is important for our framework as the app could be gigantic.
lib/framework/view/page_group.dart
Outdated
| @@ -125,16 +146,19 @@ class PageGroupState extends State<PageGroup> with MediaQueryCapability { | |||
| Drawer? drawer = _buildDrawer(context, widget.menu); | |||
| bool atStart = (widget.menu as DrawerMenu).atStart; | |||
| return PageGroupWidget( | |||
| key: UniqueKey(), | |||
There was a problem hiding this comment.
don't do this. Almost never use UniqueKey().
|
@vusters Can you review it again? Added UniqueKey only in the EnsembleBottomAppBar widget, it's not rebuilding the EnsembleBottomAppBar when the ListenableBuilder called the builder method with index. |
| @@ -99,6 +112,10 @@ class _BottomNavPageGroupState extends State<BottomNavPageGroup> | |||
| floatingAlignment = | |||
| FloatingAlignment.values.byName(fabMenuItem!.floatingAlignment); | |||
| } | |||
|
|
|||
| WidgetsBinding.instance.addPostFrameCallback((_) { | |||
There was a problem hiding this comment.
This is suboptimal. Why let it render, then re-render the correct page? Don't use this callback please.
vinothvino42
changed the title
Video:
https://drive.google.com/file/d/1HLBquNs0E1fHlIjyNnKDNFhegcma2V35/view?usp=share_link