initialise same app for firestore and auth #1821
Conversation
| @@ -58,7 +58,7 @@ class FirestoreAPIProvider extends APIProvider with LiveAPIProvider { | |||
| } else { | |||
| // Initialize the new Firebase app with the options | |||
| FirebaseApp app = await Firebase.initializeApp( | |||
| name: appId, | |||
| name: 'customFirebase', | |||
There was a problem hiding this comment.
firebase auth initialisation:
ensemble/modules/auth/lib/signin/auth_manager.dart
Lines 178 to 179 in 3b31f77
There was a problem hiding this comment.
I understand, my question was why hardcode the name of the app? is it supposed to match something somewhere else? where?
There was a problem hiding this comment.
we just need to name firebase app, since we have ensemble firebase app initialised.
Only the firebase auth and firestore need to match the name of firebase app.
Either way we'll need to have single initialisation of firebase service to not worry about matching everywhere.
There was a problem hiding this comment.
the reason I did it this way was to allow multiple apps to run in Ensemble Go and the Studio. That use case will fail if we hardcode the app name right?
There was a problem hiding this comment.
In that case, we can keep firestore initialisation as it is and update the auth side.
There was a problem hiding this comment.
yes - on the auth side we can just use the appId as well and then the two will be the same right? I am not sure if that'll be an issue or not?
Ticket: #1812