Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ensemble_schema.json for existing screens to validate against it #1790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

v-krupsky
Copy link

Changes to make existing screen definitions validate against the schema.

Main changes:

  • Widget can now be a string/null (there is usage of widgets in a string/null fashion)

  • Widget can be just an object to support user-defined widgets

  • Reworked Conditional widget to support the syntax of existing screens

  • Added Firestore API definition

  • Fixed some properties to be values or formulas - not the full list but just the things that were breaking in the validation

  • Added definitions for the following Action types: Log Event, Get Device Token, Execute Action Group, Execute Conditional Action

Had to update some screens - attaching the full list of screens and script I'm using to validate screens against schema.
attachment for EnsembleUI pull request.zip

Changes to make existing screen definitions validate against the schema.
@sharjeelyunus
Copy link
Member

sharjeelyunus commented Dec 25, 2024

Hi @v-krupsky,

The ensemble_schema.json is no longer in use. We now have TypeScript interfaces in a different repo that automatically generate the schema for studio.

@kmahmood74 shouldn't we remove the ensemble_schema.json file from here to avoid confusing people?

@kmahmood74
Copy link
Collaborator

Hi @v-krupsky,

The ensemble_schema.json is no longer in use. We now have TypeScript interfaces in a different repo that automatically generate the schema for studio.

@kmahmood74 shouldn't we remove the ensemble_schema.json file from here to avoid confusing people?

As @sharjeelyunus noted, the ensemble_schema.json is an output of the typescript schema. Even that is not the one here so we should remove from this repo.

@v-krupsky
Copy link
Author

Thank you @sharjeelyunus @kmahmood74 - could you please advise where and how can I get the current schema?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants