Fixed the bugs with the drop down #1459
Conversation
| @@ -351,6 +353,7 @@ class SelectOneState extends FormFieldWidgetState<SelectOne> | |||
|
|
|||
| return DropdownButtonFormField2<dynamic>( | |||
| key: validatorKey, | |||
| isExpanded: true, | |||
There was a problem hiding this comment.
can we really hardcode isExpanded: true like this, this will make it expand to take all the space of the parent along the mainaxis. That should not be hardcoded right?
@vusters what do you think?
There was a problem hiding this comment.
@kmahmood74 This one is primarily there to ensure that the child, ie the drop-down entities are properly in the size of the dropdown like it makes the items expanded and thus it resolves that issue in which the item was overflowing
There was a problem hiding this comment.
I know why it's there but what is the impact of this on the actual layout? I am not sure if we can hardcode isExpanded like this?
There was a problem hiding this comment.
Yes, it wont affect the layout, I did tested that one
There was a problem hiding this comment.
@hemish11 please test the isExpanded: true with long text. Create a regular dropdown and an auto-complete dropdown each with items with very long labels that overflow multiple lines. Try it with and without isExpanded: true and report the results.
| @@ -285,6 +285,8 @@ class SelectOneState extends FormFieldWidgetState<SelectOne> | |||
| validatorKey.currentState!.validate(); | |||
| } | |||
| });*/ | |||
| textEditingController = TextEditingController(text: widget.getValue()); | |||
There was a problem hiding this comment.
a few issues here -
- textEditingController needs to be disposed off in dispose
- you are setting the initial value in initState but what about updating the value as the value changes? value could be set at anytime in EDL. Also what if user selects a value, shouldn't the textEditingController be updated with that?
Please test this thoroughly
There was a problem hiding this comment.
Yes, I'll add that to the dispose method, and also testing that value of
There was a problem hiding this comment.
think about it Hemish - you are setting the value in initState which is called only once. How will it work when the developer changes value in js after the widget has already been built. Have you tested that? Can you please how it works?
| @@ -285,6 +285,8 @@ class SelectOneState extends FormFieldWidgetState<SelectOne> | |||
| validatorKey.currentState!.validate(); | |||
| } | |||
| });*/ | |||
| textEditingController = TextEditingController(text: widget.getValue()); | |||
There was a problem hiding this comment.
also check the getValue code which in turn calls isValueInItems which has the following -
if (_controller.itemTemplate != null) {
// TODO: we have no way to look into the itemTemplate to see
// if the value matches one of them. Return true for now
return true;
}looks like it just skips over when it is itemTemplate. Not sure how it will impact your fix
There was a problem hiding this comment.
Umm, Vu wrote this one, and yes we don't have a way by which we can get items from the item template, which is the same issue by which we cannot add autoCorrect with item template
| @@ -246,6 +249,8 @@ class SelectOneController extends FormFieldController with HasTextPlaceholder { | |||
| SelectOneInputFieldAction? inputFieldAction; | |||
| List<SelectOneItem>? items; | |||
|
|
|||
| TextEditingController textEditingController = TextEditingController(); | |||
There was a problem hiding this comment.
this should be handled internally in the widget, there is no need to expose it in the controller
There was a problem hiding this comment.
I needed to add it to the controller so that its available in the setters
There was a problem hiding this comment.
you don't need it to be available in the setters. You can update the value in the onchange event inside the state.
There was a problem hiding this comment.
what happens when user selects a value from the dropdown? You are setting the value when it is set in setters but what about when it is selected by user interaction? Will the textEditingController update, I don't see the code?
| @@ -73,7 +73,10 @@ abstract class SelectOne extends StatefulWidget | |||
| Map<String, Function> setters() { | |||
| var setters = _controller.textPlaceholderSetters; | |||
| setters.addAll({ | |||
| 'value': (value) => _controller.maybeValue = value, | |||
| 'value': (value) { | |||
| _controller.textEditingController.value = TextEditingValue(text: value); | |||
There was a problem hiding this comment.
this should be handled internally in the widget, there is no need to expose it in the controller
There was a problem hiding this comment.
@hemish11 I am not sure why this is needed as you just override and create a new one inside initState everytime? That was my point
| @@ -285,6 +289,9 @@ class SelectOneState extends FormFieldWidgetState<SelectOne> | |||
| validatorKey.currentState!.validate(); | |||
| } | |||
| });*/ | |||
| widget.controller.textEditingController = | |||
There was a problem hiding this comment.
why not just set value, why create a new textEditingController?
There was a problem hiding this comment.
Because to set the initial value of a text field, we must need to pass a TextEditingController so we cannot just update a value variable
| @@ -246,6 +249,8 @@ class SelectOneController extends FormFieldController with HasTextPlaceholder { | |||
| SelectOneInputFieldAction? inputFieldAction; | |||
| List<SelectOneItem>? items; | |||
|
|
|||
| TextEditingController textEditingController = TextEditingController(); | |||
There was a problem hiding this comment.
what happens when user selects a value from the dropdown? You are setting the value when it is set in setters but what about when it is selected by user interaction? Will the textEditingController update, I don't see the code?
Closes #1342 and #1292