Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading image from memory #1057

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Add support for loading image from memory #1057

merged 7 commits into from
Jan 5, 2024

Conversation

vinothvino42
Copy link
Collaborator

No description provided.

@vinothvino42 vinothvino42 requested a review from vusters December 14, 2023 14:58
@@ -154,6 +163,16 @@ class ImageState extends WidgetState<EnsembleImage> {
return "${widget.controller.source}${str}timeStamp=$lastModifiedDateTime";
}

Widget buildMemoryImage(Uint8List source) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work if it's png or svg?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working fine for PNG and JPEG formats but it not working for SVG

@kmahmood74
Copy link
Collaborator

@vinothvino42 please respond to Vu's question

@vinothvino42
Copy link
Collaborator Author

@vusters Now I added support for SVG too. Can you review it one more time?

@vinothvino42 vinothvino42 self-assigned this Jan 5, 2024
@vinothvino42 vinothvino42 changed the title WIP: Add support for loading image from memory Add support for loading image from memory Jan 5, 2024
@vinothvino42 vinothvino42 requested a review from snehmehta January 5, 2024 07:40
lib/widget/image.dart Outdated Show resolved Hide resolved
@vinothvino42 vinothvino42 merged commit 4480924 into main Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants