Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use actions in js using ensemble object #1037

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Ability to use actions in js using ensemble object #1037

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
12edb73
971-actions-in-js
Dec 4, 2023
6dc96ae
Merge branch 'main' of https://github.com/EnsembleUI/ensemble into 97…
Dec 4, 2023
e58d81d
fixed formatting
Dec 4, 2023
e9824bd
dismissModalBottom fixed
Dec 4, 2023
2521ba0
renaming fromYaml in ShowDialogAction
Dec 4, 2023
bdbf5f5
adding actions to ActionsInvokable
Dec 4, 2023
9503dd0
code review changes
Dec 6, 2023
f7070f7
Merge branch 'main' of https://github.com/EnsembleUI/ensemble into 97…
Dec 6, 2023
d53cf0d
undo-changes
Dec 6, 2023
a1e3fb8
fixing changes
Dec 6, 2023
63d199c
Merge branch 'main' of https://github.com/EnsembleUI/ensemble into 97…
Dec 6, 2023
34c3cf8
dismissBottomModal
Dec 6, 2023
11988d0
chore: removed duplicate action
Dec 6, 2023
d56fa0d
Merge branch 'main' into 971-actions-in-js
kmahmood74 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/action/action_invokable.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:ensemble/action/call_external_method.dart';
import 'package:ensemble/framework/action.dart';
import 'package:ensemble/framework/error_handling.dart';
import 'package:ensemble/framework/scope.dart';
Expand All @@ -22,6 +21,10 @@ abstract class ActionInvokable with Invokable {
ActionType.copyToClipboard,
ActionType.getDeviceToken,
ActionType.getPhoneContacts,
ActionType.showBottomModal,
ActionType.dismissBottomModal,
ActionType.showDialog,
ActionType.rateApp
nehal076 marked this conversation as resolved.
Show resolved Hide resolved
]);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/framework/data_context.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ class NativeInvokable extends ActionInvokable {
ActionType.dismissBottomModal.name: (inputs) =>
ScreenController().executeAction(
buildContext,
DismissBottomModalAction.from(),
DismissBottomModalAction.from(payload: inputs),
),
ActionType.showDialog.name: (inputs) => ScreenController()
.executeAction(buildContext, ShowDialogAction.from(payload: inputs)),
Expand Down