Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toying with setuptools #8

Merged
merged 14 commits into from
Jun 16, 2022
Merged

toying with setuptools #8

merged 14 commits into from
Jun 16, 2022

Conversation

vsitnik
Copy link
Contributor

@vsitnik vsitnik commented Jun 13, 2022

No description provided.

@vsitnik vsitnik changed the title using both setup.cfg and pyproject.toml WIP: toying with setuptools Jun 13, 2022
@vsitnik
Copy link
Contributor Author

vsitnik commented Jun 13, 2022

according to
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
and
https://peps.python.org/pep-0621/
setup.cfg should be moved to pyproject.toml

@vsitnik
Copy link
Contributor Author

vsitnik commented Jun 14, 2022

About using requirements.txt for devops (whole prod environment) and minimal build requirements (requires) see https://stackoverflow.com/a/33685899
pypa/setuptools#1951

@vsitnik
Copy link
Contributor Author

vsitnik commented Jun 14, 2022

move everything from setup.cfg to pyproject.toml (remove setup.cfg) next

@vsitnik
Copy link
Contributor Author

vsitnik commented Jun 14, 2022

requirements*txt* are substituted with the
project.dependencies and project.optional-dependencies in pyproject.toml.

I.e. use [doc] or [dev] tags to install additional dependecies

pip install -e ./ensembl-genomio[doc]

@vsitnik vsitnik changed the title WIP: toying with setuptools toying with setuptools Jun 14, 2022
JAlvarezJarreta
JAlvarezJarreta approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@JAlvarezJarreta JAlvarezJarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the pyproject.toml approach quite a lot!

pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vsitnik and others added 4 commits June 15, 2022 09:58
@vsitnik @JAlvarezJarreta
Update README.md
72c575d 
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
@vsitnik @JAlvarezJarreta
Update README.md
591300b 
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
@vsitnik @JAlvarezJarreta
Update setup.py
518ac5a 
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
@vsitnik
version moved into pyproject.toml
36abe51
ens-LCampbell
ens-LCampbell approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@ens-LCampbell ens-LCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im content with merging this PR

@vsitnik
Copy link
Contributor Author

vsitnik commented Jun 16, 2022

to do:
fix metazoan scripts lib
add poetry

@vsitnik vsitnik merged commit fb15304 into main Jun 16, 2022
@vsitnik vsitnik deleted the setup_pyproject branch June 16, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatBarba MatBarba MatBarba left review comments

@JAlvarezJarreta JAlvarezJarreta JAlvarezJarreta approved these changes

@ens-LCampbell ens-LCampbell ens-LCampbell approved these changes

@Dishalodha Dishalodha Dishalodha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsitnik @JAlvarezJarreta @MatBarba @ens-LCampbell @Dishalodha