[BazelProfile] More robust GC thread identification #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thread in which GC events are listed has been renamed multiple times, so the code for extracting the right thread by name is error-prone. Instead of testing the name, search for the GC thread by its included events. This assumes that there is only one thread that contains GC events. Contributes to #110 Signed-off-by: Sara Adams <[email protected]>
saraadams
requested review from
lrgoldstein,
restingbull,
TheGrizzlyDev and
WillEngFlow
as code owners
|
Highlighted in bazelbuild/bazel#18548 (comment) |
WillEngFlow
reviewed
Nov 22, 2023
Comment on lines
183
to
185
| .filter(event -> event.category.equals(BazelProfileConstants.CAT_GARBAGE_COLLECTION)) | ||
| .findAny() | ||
| .isPresent(); |
There was a problem hiding this comment.
You can use anyMatch((event) -> ... ) here
WillEngFlow
approved these changes
Nov 22, 2023
Signed-off-by: Sara Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thread in which GC events are listed has been renamed multiple times, so the code for extracting the right thread by name is error-prone.
Instead of testing the name, search for the GC thread by its included events. This assumes that there is only one thread that contains GC events.
Contributes to #110