Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Bazel version from profile, if present #109

Closed
saraadams opened this issue Nov 21, 2023 · 0 comments · Fixed by #108
Closed

Extract Bazel version from profile, if present #109

saraadams opened this issue Nov 21, 2023 · 0 comments · Fixed by #108
Labels
type/feat Suggests new features.

Comments

@saraadams
Copy link
Collaborator

Problem

Starting with Bazel version 6.1.0 (see bazelbuild/bazel@7569b0d), the Bazel profile includes the version of Bazel that generated the profile. There should be a DataProvider that extracts this information and makes it available for other analysis.

Additional information

Example entry in Bazel profile:

{"otherData":{"bazel_version":"release 6.1.2",...},"traceEvents":[...]}
@saraadams saraadams added the type/feat Suggests new features. label Nov 21, 2023
@saraadams saraadams mentioned this issue Nov 21, 2023
Merged
saraadams added a commit that referenced this issue Nov 22, 2023
@saraadams
[DataProvider] Extract Bazel version from profile, if present (#108)
5fe8dcf 
With Bazel release 6.1.0 the Bazel profile includes which version of
Bazel generated the profile. This PR adds a DataProvider that extracts
that information, if it is included.

Fixes #109

---------

Signed-off-by: Sara Adams <[email protected]>
saraadams added a commit that referenced this issue Nov 22, 2023
@saraadams
[BazelProfile] Make BazelVersion available in `BazelProfile
8c3a403 
The functionality provided by `BazelProfile` may need to take the Bazel version
into consideration. Therefore, this PR makes the version available within and through
the `BazelProfile`, while `BazelVersionDataProvider` stays in place to provide easier
access, as well as memoization.

Contributes to #109.

Signed-off-by: Sara Adams <[email protected]>
@saraadams saraadams mentioned this issue Nov 22, 2023
Merged
saraadams added a commit that referenced this issue Nov 24, 2023
@saraadams
[BazelProfile] Make BazelVersion available in `BazelProfile (#114)
2e5aff5 
The functionality provided by `BazelProfile` may need to take the Bazel
version into consideration. Therefore, this PR makes the version
available within and through the `BazelProfile`, while
`BazelVersionDataProvider` stays in place to provide easier access, as
well as memoization.

Contributes to #109.

---------

Signed-off-by: Sara Adams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feat Suggests new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataProvider] Extract Bazel version from profile, if present EngFlow/bazel_invocation_analyzer
1 participant
@saraadams