Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use c_char instead of i8 #56

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: Use c_char instead of i8 #56

merged 1 commit into from
Jun 13, 2022

Conversation

OlivierDehaene
Copy link

The following line is problematic as std::os::raw::c_char can either be u8 or i8 depending on the OS distribution.
I think it is possible to use c_char directly and avoid the issue.

What do you think?

Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the implementation underneath does not depend on the code type, I suppose c_char is a more fitting match for what it's in faiss-sys, and it's a crate-only function anyway. Looks good to me. Thank you!

@Enet4 Enet4 merged commit e2e012c into Enet4:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants