Add TryClone trait #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop macro `impl_native_index_clone`
|
@Enet4 Could You review it? |
Enet4
reviewed
Dec 18, 2021
There was a problem hiding this comment.
It was nice that we got rid of the macro and replaced it with something that can be applied to all implementations! 👍
It is a breaking change, but it's a reasonable one to introduce.
I found no problems in the code. Just suggesting a minor documentation tweak before we merge.
Enet4
added
the
breaking change
Co-authored-by: Eduardo Pinho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop macro
impl_native_index_cloneThis is for generic code