Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UpcastIndex trait #43

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Add UpcastIndex trait #43

merged 3 commits into from
Jul 23, 2021

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented Jul 22, 2021

from #41

Enet4
Enet4 reviewed Jul 22, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sound and it works. I would just ask you to document this new trait and its method.

src/index/mod.rs Show resolved Hide resolved
Enet4
Enet4 reviewed Jul 23, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions.

src/index/mod.rs Outdated Show resolved Hide resolved
src/index/mod.rs Outdated Show resolved Hide resolved
@Enet4 Enet4 merged commit 97753a9 into Enet4:master Jul 23, 2021
@ava57r ava57r deleted the index-upcast branch July 23, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ava57r @Enet4