Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl to_gpu for new index types #39

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Impl to_gpu for new index types #39

merged 1 commit into from
Dec 18, 2021

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented Jul 14, 2021

IVFFlatIndexImpl
IVFScalarQuantizerIndexImpl

@ava57r
Impl to_gpu for new index types
5744129 
IVFFlatIndexImpl
IVFScalarQuantizerIndexImpl
@ava57r
Copy link
Collaborator Author

ava57r commented Dec 14, 2021

@Enet4 Could You review it?

@Enet4
Copy link
Owner

Enet4 commented Dec 14, 2021

Yup, sorry. I'll remind myself to grab these pull requests this week.

@Enet4 Enet4 self-requested a review December 14, 2021 09:27
Enet4
Enet4 approved these changes Dec 18, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it amounts to following an existing pattern for the other index types. 👍 Thanks!

@Enet4 Enet4 merged commit 05d5487 into Enet4:master Dec 18, 2021
@ava57r ava57r deleted the sq-gpu branch November 28, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ava57r @Enet4