Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use impl_concurrent_index macro #34

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Use impl_concurrent_index macro #34

merged 1 commit into from
Jul 20, 2021

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented Jul 5, 2021

FlatIndexImpl
IVFFlatIndexImpl
LshIndex

@ava57r
Use impl_concurrent_index macro
fef4840 
FlatIndexImpl
IVFFlatIndexImpl
LshIndex
@ava57r ava57r requested a review from Enet4 July 5, 2021 06:11
Enet4
Enet4 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and sound! And everything still compiles with tests covering the use of ConcurrentIndex, so it seems pretty safe too. 👍

@Enet4 Enet4 merged commit 5202bb2 into Enet4:master Jul 20, 2021
@ava57r ava57r deleted the use-concurrent-index-macro branch July 20, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ava57r @Enet4