Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[faiss v1.7.1] Add Index scalar quantizer #21

Merged
merged 8 commits into from
Jun 12, 2021
Merged

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented Apr 21, 2021

bindings.rs by not released faiss API

@ava57r
Copy link
Collaborator Author

ava57r commented Apr 21, 2021

PR merged facebookresearch/faiss#1802

@ava57r ava57r changed the title [faiss not released] Add Index scalar quantizer [faiss unreleased] Add Index scalar quantizer Apr 22, 2021
@ava57r
Copy link
Collaborator Author

ava57r commented May 6, 2021

PR facebookresearch/faiss#1829 merged

@ava57r ava57r changed the title [faiss unreleased] Add Index scalar quantizer [faiss v1.7.1] Add Index scalar quantizer May 31, 2021
@Enet4 Enet4 self-requested a review June 1, 2021 08:47
@Enet4
Copy link
Owner

Enet4 commented Jun 10, 2021

Hello @ava57r. When you have the time, could you please rebase these pull requests? I brought back CI and would like to have these checked through it.

@ava57r
Copy link
Collaborator Author

ava57r commented Jun 10, 2021

I finished rebase.

Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but should be good to enter afterwards.

src/index/scalar_quantizer.rs Outdated Show resolved Hide resolved
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Enet4 Enet4 merged commit 09180c6 into Enet4:master Jun 12, 2021
@ava57r ava57r deleted the index-sq branch June 12, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants