Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: Use testcommon.etl i wholesale#587 #3089

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

refac: Use testcommon.etl i wholesale#587 #3089

wants to merge 34 commits into from
+767 −3,093

Conversation

JakobStricker
Copy link

@JakobStricker JakobStricker commented Jan 15, 2025 •
edited by henrik-t-caroe
Loading

Description

Implementation of the testcommon.etl framework into the wholesale repo.

This has been done to optimize the test procedure in the wholesale repo based on the the procedure from the measurement repo.

We have done the following:

  • Rewrite the tests in data_product, energy_calculation, and wholesale_calculation to use the testcommon framework
  • Modify the tests files to use testcommon asserts
  • Remove the 2nd run tests files (no longer used)
  • Remove the copyright section from tests (no longer necessary)

closes #587

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)

@JakobStricker JakobStricker requested a review from a team as a code owner January 15, 2025 13:04
BjarkeMeier
BjarkeMeier previously approved these changes Jan 27, 2025
View reviewed changes
@henrik-t-caroe henrik-t-caroe requested a review from a team as a code owner January 27, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrik-t-caroe henrik-t-caroe henrik-t-caroe left review comments

@BjarkeMeier BjarkeMeier BjarkeMeier left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakobStricker @BjarkeMeier @henrik-t-caroe