fix: Wholesale requests spanning a change in years #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusGraabaek
previously approved these changes
Jan 10, 2025
ebbeknudsen
reviewed
Jan 10, 2025
...e/dotnet/wholesale-api/Edi/Validation/WholesaleServicesRequest/Rules/PeriodValidationRule.cs
Outdated
Show resolved
Hide resolved
ebbeknudsen
previously approved these changes
Jan 10, 2025
lasrinnil
dismissed stale reviews from ebbeknudsen and RasmusGraabaek
via
9c3e0f8
Test results for \source\dotnet\wholesale-api\Edi.UnitTests\bin\Release\net8.0\Energinet.DataHub.Wholesale.Edi.UnitTests.dll283 tests 283 ✅ 4s ⏱️ Results for commit b92dbb7. ♻️ This comment has been updated with latest results. |
Test results for \source\dotnet\wholesale-api\WebApi.IntegrationTests\bin\Release\net8.0\Energinet.DataHub.Wholesale.WebApi.IntegrationTests.dll27 tests 24 ✅ 16s ⏱️ Results for commit b92dbb7. ♻️ This comment has been updated with latest results. |
ebbeknudsen
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow requests for wholesale series which overlap a year on local date time.
PeriodValidationRulenow inspects a if the month differ more than 1 from each other, and the year of start and end period is between each other (1), then the start and end of the month is allowed to be -11Added a test to ensure the cased described is working as intended.
Reference: https://app.zenhub.com/workspaces/mosaic-60a6105157304f00119be86e/issues/gh/energinet-datahub/internal-repo/1535
Pull-request quality
dev_002)