Add measurements ci workflow with proto compile job #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaBloze
reviewed
Jan 10, 2025
Comment on lines
+53
to
+54
| measurements: | ||
| - 'source/measurements/**' |
There was a problem hiding this comment.
should protobuf compile always be triggered when there are changes in measurements?
There was a problem hiding this comment.
Changed to only compile proto on changes to /contracts folder
| @@ -0,0 +1,23 @@ | |||
| name: CI Measurements | |||
There was a problem hiding this comment.
Maybe this should be a CI Protobuf? Not should if it would make sense and how often we should do this
There was a problem hiding this comment.
I think it should run as part of the measurements (or what wi call it.. bronze?), but only trigger on changes to the contracts folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull-request quality
dev_002)