Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: WhenArchivedMessageIsCreatedTests #1428

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

lasrinnil
Copy link
Contributor

@lasrinnil lasrinnil commented Dec 23, 2024

Description

This PR moves the WhenArchivedMessageIsCreatedTests from the "old" IntegrationTest project into the ArchivedMessage.IntegrationTest.

  • Some tests have been rewritten to a simpler approach
  • A single test have been removed.
    • This was dont because ArchivedMessages FileStorageReference Id is now always made with a unique id when using the ArchivedMessageDto
      image

References

This change has no reference, its simply boyscout'ing 🫡

Checklist

  • Should the change be behind a feature flag?
  • Can the feature be meaningfully disabled or circumvented if there are issues (e.g., database-breaking changes)?
  • Has it been considered whether data is being delivered to the wrong actor?
  • Subsystem test executed (dev_002/dev_003)
  • Is there time to monitor state of the release to Production?
  • Reference to the task

@lasrinnil lasrinnil requested a review from a team as a code owner December 23, 2024 13:33
@lasrinnil lasrinnil requested review from ManBearTM and removed request for a team December 23, 2024 13:33
Copy link

github-actions bot commented Dec 23, 2024

Test results for \source\IntegrationTests\bin\Release\net8.0\Energinet.DataHub.EDI.IntegrationTests.dll

289 tests   289 ✅  56s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 1b3ef98.

♻️ This comment has been updated with latest results.

@lasrinnil lasrinnil merged commit 1a9e5e7 into main Jan 3, 2025
49 checks passed
@lasrinnil lasrinnil deleted the lrn_move_archivedmessage_int_tests branch January 3, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants