-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Read Point from Period and not Series elements #1426
Conversation
Test results for \source\Tests\bin\Release\net8.0\Energinet.DataHub.EDI.Tests.dll1 573 tests 1 573 ✅ 16s ⏱️ Results for commit be2ac08. ♻️ This comment has been updated with latest results. |
|
Description
Series
element, instead of thePeriod
for JSON.Point
always had all its values for JSON. This is incorrect, as two of them are nullable.Observation
GivenIncomingMessagesWithDelegationTests
relies on eBix for RSM-12. It should work for XML/JSON too, but it does not. We should fix this in another PR.References
https://app.zenhub.com/workspaces/mosaic-60a6105157304f00119be86e/issues/gh/energinet-datahub/team-mosaic/377
Checklist