Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Read Point from Period and not Series elements #1426

Merged
merged 11 commits into from
Dec 23, 2024

Conversation

MWO1024
Copy link
Contributor

@MWO1024 MWO1024 commented Dec 19, 2024

Description

  • We accidentally read the points from the Series element, instead of the Period for JSON.
  • We assumed that a Point always had all its values for JSON. This is incorrect, as two of them are nullable.
  • We created a lot of points for our behaviour tests. This is now reduced to four: one for each structural case.
  • We did not handle decimals correctly wrt assertion and temporary serialisation.

Observation

  • GivenIncomingMessagesWithDelegationTests relies on eBix for RSM-12. It should work for XML/JSON too, but it does not. We should fix this in another PR.

References

https://app.zenhub.com/workspaces/mosaic-60a6105157304f00119be86e/issues/gh/energinet-datahub/team-mosaic/377

Checklist

  • Should the change be behind a feature flag?
  • Can the feature be meaningfully disabled or circumvented if there are issues (e.g., database-breaking changes)?
  • Has it been considered whether data is being delivered to the wrong actor?
  • Subsystem test executed (dev_002/dev_003)
  • Is there time to monitor state of the release to Production?
  • Reference to the task

@MWO1024 MWO1024 requested a review from a team as a code owner December 19, 2024 13:05
Copy link

github-actions bot commented Dec 19, 2024

Test results for \source\Tests\bin\Release\net8.0\Energinet.DataHub.EDI.Tests.dll

1 573 tests   1 573 ✅  16s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit be2ac08.

♻️ This comment has been updated with latest results.

@lasrinnil
Copy link
Contributor

  • Reverted 'RequestAndPeekFormatPairs' approch - while it is technically plausible for a actor to request in one format, and peek in another. It is not the inteded use, and not how the system is used by the actors.

  • Observation: if all new messages we are yet to support have the same amounts of integrationtests I worry for this test approach.

    • Almost all of these tests have nothing to do with the specific messagetype under test.
    • Could we go with another approch to make sure that these tests would not have to be made for every type we support?

@lasrinnil lasrinnil merged commit 043b2d3 into main Dec 23, 2024
49 checks passed
@lasrinnil lasrinnil deleted the mwo/json-par-fix-and-beh-tes branch December 23, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants