-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac: Refactor PM shared test fixtures #1383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:34 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:35 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 21, 2024 15:51 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 15:11 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 15:11 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 15:11 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 15:11 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 15:11 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 15:11 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 15:11 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
ebbeknudsen
temporarily deployed
to
AzureAuth
November 27, 2024 18:37 — with
GitHub Actions
Inactive
dstenroejl
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Process Manager tests to share and use managers for running the different apps, instead of sharing and using multiple fixture.
Before
MonitorCalculationUsingClientsScenario
ScenarioProcessManagerAppFixture
(shared)OrchestrationsAppFixture
(shared)After
MonitorCalculationUsingClientsScenario
ProcessManagerClientFixture
ProcessManagerAppManager
(shared)OrchestrationsAppManager
(shared)References
Checklist
COPILOT SUMMARY 🤣 🔥
This pull request involves significant changes to the test fixtures and integration tests in the
ProcessManager.Client.Tests
project. The primary focus is on consolidating and simplifying the test setup by introducing a newProcessManagerClientFixture
and removing redundant fixtures.Test Fixture Consolidation:
ProcessManagerClientCollection.cs
: Updated to useProcessManagerClientFixture
instead ofScenarioProcessManagerAppFixture
andScenarioOrchestrationsAppFixture
.ProcessManagerClientFixture.cs
: Introduced a new fixture to manage common test setup tasks, including initializing and disposing resources.Removal of Redundant Fixtures:
ScenarioAppFixturesConfiguration.cs
,ScenarioOrchestrationsAppFixture.cs
, andScenarioProcessManagerAppFixture.cs
: Removed these redundant fixtures as their responsibilities are now handled byProcessManagerClientFixture
. [1] [2] [3]Integration Test Updates:
RequestCalculatedEnergyTimeSeriesTests.cs
: Updated to useProcessManagerClientFixture
and refactored the test to use the new fixture setup. [1] [2]MonitorCalculationUsingApiScenario.cs
andMonitorCalculationUsingClientsScenario.cs
: Updated to useProcessManagerClientFixture
and refactored methods to align with the new fixture. [1] [2] [3] [4] [5] [6]Project File Updates:
ProcessManager.Client.Tests.csproj
: Updated to include new fixture files and remove references to old fixture base classes.