Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: Refactor PM shared test fixtures #1383

Merged
merged 22 commits into from
Nov 27, 2024
Merged

Conversation

ebbeknudsen
Copy link
Contributor

@ebbeknudsen ebbeknudsen commented Nov 21, 2024

Description

Refactor Process Manager tests to share and use managers for running the different apps, instead of sharing and using multiple fixture.

Before

  • MonitorCalculationUsingClientsScenario
    • ScenarioProcessManagerAppFixture (shared)
    • OrchestrationsAppFixture (shared)

After

  • MonitorCalculationUsingClientsScenario
    • ProcessManagerClientFixture
      • ProcessManagerAppManager (shared)
      • OrchestrationsAppManager (shared)

References

Checklist

  • Should the change be behind a feature flag?
  • Can the feature be meaningfully disabled or circumvented if there are issues (e.g., database-breaking changes)?
  • Has it been considered whether data is being delivered to the wrong actor?
  • Subsystem test executed (dev_002/dev_003)
  • Is there time to monitor state of the release to Production?
  • Reference to the task

COPILOT SUMMARY 🤣 🔥

This pull request involves significant changes to the test fixtures and integration tests in the ProcessManager.Client.Tests project. The primary focus is on consolidating and simplifying the test setup by introducing a new ProcessManagerClientFixture and removing redundant fixtures.

Test Fixture Consolidation:

Removal of Redundant Fixtures:

  • ScenarioAppFixturesConfiguration.cs, ScenarioOrchestrationsAppFixture.cs, and ScenarioProcessManagerAppFixture.cs: Removed these redundant fixtures as their responsibilities are now handled by ProcessManagerClientFixture. [1] [2] [3]

Integration Test Updates:

  • RequestCalculatedEnergyTimeSeriesTests.cs: Updated to use ProcessManagerClientFixture and refactored the test to use the new fixture setup. [1] [2]
  • MonitorCalculationUsingApiScenario.cs and MonitorCalculationUsingClientsScenario.cs: Updated to use ProcessManagerClientFixture and refactored methods to align with the new fixture. [1] [2] [3] [4] [5] [6]

Project File Updates:

Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstenroejl dstenroejl merged commit 295ee6d into main Nov 27, 2024
50 checks passed
@dstenroejl dstenroejl deleted the xedkn/pm-request-tests branch November 27, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants