Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: 3. refactor outgoing messages to clean architecture #1380

Merged
merged 31 commits into from
Nov 28, 2024
Merged

refac: 3. refactor outgoing messages to clean architecture #1380

merged 31 commits into from
Nov 28, 2024

Conversation

AndersBallingPetersen
Copy link
Contributor

Description

This module adheres to the illustration below.

image

References

Checklist

  • Should the change be behind a feature flag?
  • Can the feature be meaningfully disabled or circumvented if there are issues (e.g., database-breaking changes)?
  • Has it been considered whether data is being delivered to the wrong actor?
  • Subsystem test executed (dev_002/dev_003)
  • Is there time to monitor state of the release to Production?
  • Reference to the task

AndersBallingPetersen and others added 23 commits November 8, 2024 15:20
@AndersBallingPetersen
Refactored MasterData module to clean architecture
950df3e
@AndersBallingPetersen
Refactor ArchivedMessages to clean architecture
935f484
@AndersBallingPetersen
wip
721a8a4
@ebbeknudsen
Merge branch 'main' into xabpe/Refactor-MasterData-to-clean-architecture
31672e2
@AndersBallingPetersen
Create wrapper interface for MasterDataContext
ad88a7d
@AndersBallingPetersen
Merge branch 'main' into xabpe/Refactor-MasterData-to-clean-architecture
7d4a887
@AndersBallingPetersen
Merge branch 'xabpe/Refactor-MasterData-to-clean-architecture' into x…
f49476d 
…abpe/1-Refactor-ArchivedMessages-to-clean-architecture
@AndersBallingPetersen
Merge branch 'xabpe/1-Refactor-ArchivedMessages-to-clean-architecture…
1aa4f2e 
…' into xabpe/2-Refactor-BuildingBlocks-to-clean-architecture
@AndersBallingPetersen
Merge branch 'main' into xabpe/Refactor-MasterData-to-clean-architecture
d0240f6
@AndersBallingPetersen
Refactor BuildingBlocks to Clean Architecture
bcefc8f
@AndersBallingPetersen
Merge branch 'main' into xabpe/Refactor-MasterData-to-clean-architecture
32ac8f8
@AndersBallingPetersen
Added Domain project and mapping to ArchivedMessages
797944f
@AndersBallingPetersen
Merge branch 'xabpe/Refactor-MasterData-to-clean-architecture' into x…
c1a83c7 
…abpe/1-Refactor-ArchivedMessages-to-clean-architecture
@AndersBallingPetersen
Merge branch 'main' into xabpe/1-Refactor-ArchivedMessages-to-clean-a…
b0a5351 
…rchitecture
@AndersBallingPetersen
Merge branch 'xabpe/1-Refactor-ArchivedMessages-to-clean-architecture…
438bfac 
…' into xabpe/2-Refactor-BuildingBlocks-to-clean-architecture
@AndersBallingPetersen
Merge branch 'main' into xabpe/2-Refactor-BuildingBlocks-to-clean-arc…
cdc92d8 
…hitecture
@AndersBallingPetersen
Fixed namespaces and .csproj propertygroups
c9e78bd
@AndersBallingPetersen
Fixed typo
4260995
@AndersBallingPetersen
Fix namespaces
026553c
@AndersBallingPetersen
Refactor OutgoingMessages to clean architecture
1329412
@AndersBallingPetersen
Fixed namespaces
52182e2
@AndersBallingPetersen
Merge branch 'main' into xabpe/2-Refactor-BuildingBlocks-to-clean-arc…
c485e42 
…hitecture
@AndersBallingPetersen
Merge branch 'xabpe/2-Refactor-BuildingBlocks-to-clean-architecture' …
c11f849 
…into xabpe/3-Refactor-OutgoingMessages-to-clean-architecture
@AndersBallingPetersen AndersBallingPetersen requested a review from a team as a code owner November 21, 2024 09:15
@AndersBallingPetersen AndersBallingPetersen changed the title 3 refactor outgoing messages to clean architecture refac: 3. refactor outgoing messages to clean architecture Nov 21, 2024
@RasmusGraabaek RasmusGraabaek enabled auto-merge (squash) November 28, 2024 11:32
@RasmusGraabaek RasmusGraabaek merged commit 1396347 into main Nov 28, 2024
48 checks passed
@RasmusGraabaek RasmusGraabaek deleted the xabpe/3-Refactor-OutgoingMessages-to-clean-architecture branch November 28, 2024 11:48
MadsDue added a commit that referenced this pull request Nov 29, 2024
@AndersBallingPetersen @ebbeknudsen
@dstenroejl @MadsDue @RasmusGraabaek
refac: 3. refactor outgoing messages to clean architecture (#1380)
8254a8e 
* Refactored MasterData module to clean architecture

* Refactor ArchivedMessages to clean architecture

* wip

* Create wrapper interface for MasterDataContext

* Refactor BuildingBlocks to Clean Architecture

* Added Domain project and mapping to ArchivedMessages

* Fixed namespaces and .csproj propertygroups

* Fixed typo

* Fix namespaces

* Refactor OutgoingMessages to clean architecture

* Fixed namespaces

---------

Co-authored-by: Ebbe Knudsen <[email protected]>
Co-authored-by: Dan Stenrøjl <[email protected]>
Co-authored-by: Mads Magnus Due <[email protected]>
Co-authored-by: RasmusGraabaek <[email protected]>
MadsDue added a commit that referenced this pull request Nov 29, 2024
@MadsDue
feat: added json document writer for rsm012 (#1406)
b49a13c 
* refac: 3. refactor outgoing messages to clean architecture (#1380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadsDue MadsDue MadsDue approved these changes

@ebbeknudsen ebbeknudsen Awaiting requested review from ebbeknudsen ebbeknudsen is a code owner automatically assigned from Energinet-DataHub/team-mosaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndersBallingPetersen @MadsDue @RasmusGraabaek @dstenroejl @ebbeknudsen