Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: 1. refactor archived messages to clean architecture #1358

Merged
merged 13 commits into from
Nov 15, 2024
Merged

refac: 1. refactor archived messages to clean architecture #1358

merged 13 commits into from
Nov 15, 2024

Conversation

AndersBallingPetersen
Copy link
Contributor

@AndersBallingPetersen AndersBallingPetersen commented Nov 13, 2024 •
edited
Loading

Description

This module adheres to the illustration below.

image

References

Checklist

  • Should the change be behind a feature flag?
  • Can the feature be meaningfully disabled or circumvented if there are issues (e.g., database-breaking changes)?
  • Has it been considered whether data is being delivered to the wrong actor?
  • Subsystem test executed (dev_002/dev_003)
  • Is there time to monitor state of the release to Production?
  • Reference to the task

@AndersBallingPetersen AndersBallingPetersen requested a review from a team as a code owner November 13, 2024 11:06
@AndersBallingPetersen AndersBallingPetersen changed the title refac: 1 refactor archived messages to clean architecture refac: 1. refactor archived messages to clean architecture Nov 13, 2024
MadsDue
MadsDue previously approved these changes Nov 13, 2024
View reviewed changes
source/ArchivedMessages.Interfaces/IArchivedMessageRepository.cs Outdated Show resolved Hide resolved
@AndersBallingPetersen AndersBallingPetersen merged commit 05a516c into main Nov 15, 2024
48 checks passed
@AndersBallingPetersen AndersBallingPetersen deleted the xabpe/1-Refactor-ArchivedMessages-to-clean-architecture branch November 15, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadsDue MadsDue MadsDue approved these changes

@energinet-ajw energinet-ajw Awaiting requested review from energinet-ajw energinet-ajw is a code owner automatically assigned from Energinet-DataHub/team-mosaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndersBallingPetersen @MadsDue @ebbeknudsen