Merge pull request #278 from Energinet-DataHub/batrman/beating_a_dead…

…_horse refac: removed unneeded code
Energinet-DataHub · May 30, 2023 · 668e990 · 668e990
2 parents 765ea20 + c7d7159
commit 668e990
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/source/Application/Configuration/Authentication/MarketActorIdentity.cs b/source/Application/Configuration/Authentication/MarketActorIdentity.cs
@@ -32,6 +32,10 @@ protected MarketActorIdentity(string id, ActorNumber? number, IEnumerable<Market
 
         public string Id { get; }
 
+        /// <summary>
+        /// Actor number.
+        /// TODO AJW: Remove nullable.
+        /// </summary>
         public ActorNumber? Number { get; }
 
         public bool HasRole(string role)

diff --git a/source/CimMessageAdapter/Messages/MessageReceiver.cs b/source/CimMessageAdapter/Messages/MessageReceiver.cs
@@ -53,12 +53,11 @@ public async Task<Result> ReceiveAsync<TMarketActivityRecordType, TMarketTransac
             var messageHeader = messageParserResult.IncomingMarketDocument?.Header;
             var marketDocument = messageParserResult.IncomingMarketDocument;
 
-            if (InvalidMessageHeader(messageHeader))
+            if (messageHeader is null)
             {
                 return Result.Failure(messageParserResult.Errors.ToArray());
             }
 
-            ArgumentNullException.ThrowIfNull(messageHeader);
             ArgumentNullException.ThrowIfNull(marketDocument);
 
             await AuthorizeSenderAsync(messageHeader).ConfigureAwait(false);
@@ -93,11 +92,6 @@ public async Task<Result> ReceiveAsync<TMarketActivityRecordType, TMarketTransac
             return Result.Succeeded();
         }
 
-        private static bool InvalidMessageHeader(MessageHeader? header)
-        {
-            return header is null;
-        }
-
         private Task<bool> CheckTransactionIdAsync(string transactionId, CancellationToken cancellationToken)
         {
             if (transactionId == null) throw new ArgumentNullException(nameof(transactionId));
@@ -132,14 +126,12 @@ private async Task CheckMessageIdAsync(string messageId, CancellationToken cance
 
         private async Task AuthorizeSenderAsync(MessageHeader messageHeader)
         {
-            if (messageHeader == null) throw new ArgumentNullException(nameof(messageHeader));
             var result = await _senderAuthorizer.AuthorizeAsync(messageHeader.SenderId, messageHeader.SenderRole).ConfigureAwait(false);
             _errors.AddRange(result.Errors);
         }
 
         private async Task VerifyReceiverAsync(MessageHeader messageHeader)
         {
-            if (messageHeader == null) throw new ArgumentNullException(nameof(messageHeader));
             var receiverVerification = await ReceiverVerification.VerifyAsync(messageHeader.ReceiverId, messageHeader.ReceiverRole).ConfigureAwait(false);
             _errors.AddRange(receiverVerification.Errors);
         }