Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for extension with support for GH actions to Dependabot configuration #229

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonasbn
Copy link

@jonasbn jonasbn commented Dec 23, 2021

Description

Hello,

I wanted to propose an update to you spellcheck action configuration, but I saw that you were using Dependabot, so instead I am proposing a configuration for keeping your GitHub actions up to date.

If you would prefer to manually handle these, please let me know and I will create a PR with a proposal for an update to the Spellcheck action.

References

  • None

…configuration

Hello,

I wanted to propose an update to you spellcheck action configuration, but I saw that you were using Dependabot, so instead I am proposing a configuration for keeping your GitHub actions up to date.

If you would prefer to manually handle these, please let me know and I will create a PR with a proposal for an update to the Spellcheck action.
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2021

CLA assistant check
All committers have signed the CLA.

@cla-bot
Copy link

cla-bot bot commented Jun 8, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jonasbn on file. In order for us to review and merge your code, please follow the instructions at https://github.com/Energinet-DataHub/clabot-config/blob/main/README.md.

@renenielsendk
Copy link

Hi @jonasbn Thanks for your contribution.
Sorry for the delay of answering, this domain has been quite overlooked.

Unfortunately we are actually removing all code from this repository, to keep it more as a documentation repo.
You are more than welcome to make pull requests to other repositories with your contribution.

@jonasbn
Copy link
Author

jonasbn commented Jun 10, 2022

Hi @Renetnielsen

Do note the PR was not aimed at code, but your Dependabot configuration. By adding a configuration for automatic updating of GitHub Actions, as offered by Dependabot. That would include actions such as the spellchecking action rojopolis/spellcheck-github-actions for which I am the maintainer.

You are currently using version 0.5.0 of that particular action which is very old, the latest version being 0.24.0. I could create a PR to bump that, but utilizing Dependabot seemed like a better and more long term solution.

If you plan to keep your documentation in Markdown and make use of tools like the spellchecker, consider using Dependabot to keep this part of your project up to date or at least bump the version of the spellchecker to something more contemporary.

@renenielsendk
Copy link

Hi @jonasbn

My bad, i was not that into what it actually did.
But you are completely correct, since we use the actions for spellchecking and similar, we could use this contribution.

I will reopen it.

You will be the first actual outside contributor to help us check the current temp cla button we have.
Can you check out the README in this repo and follow that flow, and validate if its actually possible for you since you are not in the organisation.
https://github.com/Energinet-DataHub/clabot-config/blob/main/README.md

@renenielsendk renenielsendk reopened this Jun 10, 2022
@cla-bot
Copy link

cla-bot bot commented Jun 10, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jonasbn on file. In order for us to review and merge your code, please follow the instructions at https://github.com/Energinet-DataHub/clabot-config/blob/main/README.md.

@cla-bot
Copy link

cla-bot bot commented Jun 10, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jonasbn on file. In order for us to review and merge your code, please follow the instructions at https://github.com/Energinet-DataHub/clabot-config/blob/main/README.md.

@jonasbn
Copy link
Author

jonasbn commented Jun 10, 2022

Don't sweat it @Renetnielsen it is just a PR, glad you reconsidered howeever and I hope you will continue to use the spellcheck GHA and that my contributions via that will bring your project value.

I will look at the CLA later today

@jonasbn
Copy link
Author

jonasbn commented Jun 10, 2022

I have agreed to the CLA in Energinet-DataHub/clabot-config/pull/6 but it requires privileges to merge, it does not seem as if the documentation is up to date on this point:

  1. Disregard the cla-bot check, and merge your pull request into the main branch (no approval needed)

REF: Energinet-DataHub/clabot-config/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants