Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add python settlement reports #72

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: add python settlement reports #72

wants to merge 15 commits into from

Conversation

cenh-halfspace
Copy link

@cenh-halfspace cenh-halfspace commented Dec 3, 2024 •
edited
Loading

Description

Moved current code from wholesale for settlement reports job (option 2) to this repo. Added CI pipeline for running python unit and integration tests.

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Python test results

2 tests   2 ✅  4m 16s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c85c923.

♻️ This comment has been updated with latest results.

@cenh-halfspace cenh-halfspace marked this pull request as ready for review December 9, 2024 09:58
@cenh-halfspace cenh-halfspace requested review from a team as code owners December 9, 2024 09:58
JesperGomes
JesperGomes reviewed Dec 17, 2024
View reviewed changes
Copy link

@JesperGomes JesperGomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that settlement the report job might have been update while this PR is being reviewed (a new name for the metering point type is beening introduced)

JesperGomes
JesperGomes reviewed Dec 17, 2024
View reviewed changes
...ort_python/settlement_report_job/infrastructure/wholesale/data_values/metering_point_type.py
TOTAL_CONSUMPTION = "total_consumption"
ELECTRICAL_HEATING = "electrical_heating"
NET_CONSUMPTION = "net_consumption"
EFFECT_SETTLEMENT = "effect_settlement"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that settlement the report job might have been update while this PR is being reviewed (a new name for the metering point type is beening introduced)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesperGomes JesperGomes JesperGomes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cenh-halfspace @JesperGomes