Updates after review

Energinet-DataHub · Oct 30, 2024 · e66ac92 · e66ac92
1 parent a839555
commit e66ac92
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/...-report/SettlementReports.Application/SettlementReports_v2/ISettlementReportRepository.cs b/...-report/SettlementReports.Application/SettlementReports_v2/ISettlementReportRepository.cs
@@ -32,5 +32,5 @@ public interface ISettlementReportRepository
 
     Task<IEnumerable<SettlementReport>> GetForJobsAsync(Guid actorId);
 
-    Task<IEnumerable<SettlementReport>> GetNeedsNotificationSentForCompletedAndFailed();
+    Task<IEnumerable<SettlementReport>> GetPendingNotificationsForCompletedAndFailed();
 }
diff --git a/source/settlement-report/SettlementReports.Function/Program.cs b/source/settlement-report/SettlementReports.Function/Program.cs
@@ -22,11 +22,7 @@
 using Microsoft.Extensions.Hosting;
 
 var host = new HostBuilder()
-    .ConfigureFunctionsWebApplication(worker =>
-    {
-        // Http => Authentication
-        worker.UseUserMiddlewareForIsolatedWorker<FrontendUser>();
-    })
+    .ConfigureFunctionsWebApplication()
     .ConfigureServices((context, services) =>
     {
         // Common

diff --git a/...tlement-report/SettlementReports.Infrastructure/Notifications/IntegrationEventProvider.cs b/...tlement-report/SettlementReports.Infrastructure/Notifications/IntegrationEventProvider.cs
@@ -32,7 +32,7 @@ public IntegrationEventProvider(ISettlementReportRepository settlementReportRepo
     public async IAsyncEnumerable<IntegrationEvent> GetAsync()
     {
         var reportsForNotifications = await _settlementReportRepository
-            .GetNeedsNotificationSentForCompletedAndFailed()
+            .GetPendingNotificationsForCompletedAndFailed()
             .ConfigureAwait(false);
 
         foreach (var reportForNotification in reportsForNotifications)

diff --git a/...tReports.Infrastructure/Persistence/SettlementReportRequest/SettlementReportRepository.cs b/...tReports.Infrastructure/Persistence/SettlementReportRequest/SettlementReportRepository.cs
@@ -91,7 +91,7 @@ public async Task DeleteAsync(Application.SettlementReports_v2.SettlementReport
             .ConfigureAwait(false);
     }
 
-    public async Task<IEnumerable<Application.SettlementReports_v2.SettlementReport>> GetNeedsNotificationSentForCompletedAndFailed()
+    public async Task<IEnumerable<Application.SettlementReports_v2.SettlementReport>> GetPendingNotificationsForCompletedAndFailed()
     {
         return await _context.SettlementReports
             .Where(x => x.IsNotificationSent == false && (x.Status == SettlementReportStatus.Completed || x.Status == SettlementReportStatus.Failed))

diff --git a/...nTests/Infrastructure/SettlementReports_v2/Persistence/SettlementReportRepositoryTests.cs b/...nTests/Infrastructure/SettlementReports_v2/Persistence/SettlementReportRepositoryTests.cs
@@ -325,7 +325,7 @@ await PrepareNewRequestAsync(requestFilterDto =>
         var repository = new SettlementReportRepository(context);
 
         // act
-        var actual = (await repository.GetNeedsNotificationSentForCompletedAndFailed()).ToList();
+        var actual = (await repository.GetPendingNotificationsForCompletedAndFailed()).ToList();
 
         // assert
         Assert.Empty(actual);
@@ -348,7 +348,7 @@ public async Task GetForNotificationAsync_ReturnsCorrect_WhenTheyArePresent()
             request.MarkAsCompleted(SystemClock.Instance, new GeneratedSettlementReportDto(new SettlementReportRequestId(request.Id.ToString()), "test.zip",  []));
             return request;
         });
-        await PrepareNewRequestAsync(requestFilterDto =>
+        var alreadySent = await PrepareNewRequestAsync(requestFilterDto =>
         {
             var request = new SettlementReport.Application.SettlementReports_v2.SettlementReport(
                 SystemClock.Instance,
@@ -366,11 +366,15 @@ await PrepareNewRequestAsync(requestFilterDto =>
         var repository = new SettlementReportRepository(context);
 
         // act
-        var actual = (await repository.GetNeedsNotificationSentForCompletedAndFailed()).ToList();
+        var actual = (await repository.GetPendingNotificationsForCompletedAndFailed()).ToList();
+        var actualSent = await repository.GetAsync(alreadySent.RequestId);
 
         // assert
         Assert.Single(actual);
+        Assert.NotNull(actualSent);
         Assert.Equal(expected.Id, actual[0].Id);
+        Assert.False(actual[0].IsNotificationSent);
+        Assert.True(actualSent.IsNotificationSent);
     }
 
     private async Task<SettlementReport.Application.SettlementReports_v2.SettlementReport> PrepareNewRequestAsync(Func<SettlementReportRequestFilterDto, SettlementReport.Application.SettlementReports_v2.SettlementReport>? createReport = null)