Merge branch 'main' into juj/ChangeEnergySupplierIdParamForJob

Energinet-DataHub · Oct 7, 2024 · bffb2ab · bffb2ab
2 parents 6504f5b + 1aa0965
commit bffb2ab
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 20 deletions.
diff --git a/...stration.SettlementReports/Functions/SettlementReports/SettlementReportListHttpTrigger.cs b/...stration.SettlementReports/Functions/SettlementReports/SettlementReportListHttpTrigger.cs
@@ -99,19 +99,19 @@ private async Task<IEnumerable<RequestedSettlementReportDto>> CheckStatusOfSettl
         {
             var updatedReport = settlementReport;
 
-            var instanceInfo = await durableTaskClient
-                .GetInstanceAsync(settlementReport.RequestId.Id, getInputsAndOutputs: true)
-                .ConfigureAwait(false);
-
-            if (instanceInfo == null)
+            if (settlementReport.Status == SettlementReportStatus.InProgress && settlementReport.JobId == null)
             {
-                // If the orchestration instance is not found, we assume it is running on the other orchestration,
-                // either the heavy or the light one
-                continue;
-            }
+                var instanceInfo = await durableTaskClient
+                    .GetInstanceAsync(settlementReport.RequestId.Id, getInputsAndOutputs: true)
+                    .ConfigureAwait(false);
+
+                if (instanceInfo == null)
+                {
+                    // If the orchestration instance is not found, we assume it is running on the other orchestration,
+                    // either the heavy or the light one
+                    continue;
+                }
 
-            if (settlementReport.Status == SettlementReportStatus.InProgress)
-            {
                 if (instanceInfo.RuntimeStatus
                     is OrchestrationRuntimeStatus.Terminated
                     or OrchestrationRuntimeStatus.Failed)

diff --git a/...lement-report/SettlementReports.Infrastructure/Experimental/DatabricksSqlQueryExecutor.cs b/...lement-report/SettlementReports.Infrastructure/Experimental/DatabricksSqlQueryExecutor.cs
@@ -63,7 +63,7 @@ internal string BuildDebugString(DatabricksSqlQueryable query)
 
     private IAsyncEnumerable<TElement> ExecuteCoreAsync<TElement>(DatabricksStatement databricksStatement, CancellationToken cancellationToken = default)
     {
-        var rows = _databricksSqlWarehouseQueryExecutor.ExecuteStatementAsync(databricksStatement, QueryOptions.WithFormat(Format.JsonArray).WithParallelDownload(), cancellationToken);
+        var rows = _databricksSqlWarehouseQueryExecutor.ExecuteStatementAsync(databricksStatement, QueryOptions.WithFormat(Format.JsonArray), cancellationToken);
         return _sqlRowHydrator.HydrateAsync<TElement>(rows, cancellationToken);
     }
 

diff --git a/...ementReports.Infrastructure/SettlementReports_v2/Generators/MonthlyAmountFileGenerator.cs b/...ementReports.Infrastructure/SettlementReports_v2/Generators/MonthlyAmountFileGenerator.cs
@@ -75,7 +75,10 @@ public SettlementReportMonthlyAmountRowMap()
                     Resolution.Hour => "PT1H",
                     Resolution.Day => "P1D",
                     Resolution.Month => "P1M",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.Resolution)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.Resolution),
+                        row.Value.Resolution,
+                        "Value does not contain a enum representation of a Resolution"),
                 });
 
             Map(r => r.QuantityUnit)
@@ -86,7 +89,10 @@ public SettlementReportMonthlyAmountRowMap()
                     null => string.Empty,
                     QuantityUnit.Kwh => "KWH",
                     QuantityUnit.Pieces => "PCS",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.QuantityUnit)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.QuantityUnit),
+                        row.Value.QuantityUnit,
+                        string.Empty),
                 });
 
             Map(r => r.Currency)
@@ -95,7 +101,10 @@ public SettlementReportMonthlyAmountRowMap()
                 .Convert(row => row.Value.Currency switch
                 {
                     Currency.DKK => "DKK",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.Currency)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.Currency),
+                        row.Value.Currency,
+                        "Value does not contain a enum representation of a Currency"),
                 });
 
             Map(r => r.Amount)
@@ -112,7 +121,10 @@ public SettlementReportMonthlyAmountRowMap()
                     ChargeType.Tariff => "D03",
                     ChargeType.Fee => "D02",
                     ChargeType.Subscription => "D01",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.ChargeType)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.ChargeType),
+                        row.Value.ChargeType,
+                        "Value does not contain a enum representation of a ChargeType"),
                 });
 
             Map(r => r.ChargeCode)

diff --git a/...Reports.Infrastructure/SettlementReports_v2/Generators/MonthlyAmountTotalFileGenerator.cs b/...Reports.Infrastructure/SettlementReports_v2/Generators/MonthlyAmountTotalFileGenerator.cs
@@ -81,17 +81,24 @@ public SettlementReportTotalMonthlyAmountRowMap(SettlementReportRequestedByActor
                     Resolution.Hour => "PT1H",
                     Resolution.Day => "P1D",
                     Resolution.Month => "P1M",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.Resolution)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.Resolution),
+                        row.Value.Resolution,
+                        "Value does not contain a enum representation of a Resolution."),
                 });
 
             Map(r => r.QuantityUnit)
                 .Name("MEASUREUNIT")
                 .Index(6)
                 .Convert(row => row.Value.QuantityUnit switch
                 {
+                    null => string.Empty,
                     QuantityUnit.Kwh => "KWH",
                     QuantityUnit.Pieces => "PCS",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.QuantityUnit)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.QuantityUnit),
+                        row.Value.QuantityUnit,
+                        "Value does not contain a enum representation of a quantity unit."),
                 });
 
             Map(r => r.Currency)
@@ -100,7 +107,10 @@ public SettlementReportTotalMonthlyAmountRowMap(SettlementReportRequestedByActor
                 .Convert(row => row.Value.Currency switch
                 {
                     Currency.DKK => "DKK",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.Currency)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.Currency),
+                        row.Value.Currency,
+                        "Value does not contain a enum representation of a Currency"),
                 });
 
             Map(r => r.Amount)
@@ -117,7 +127,10 @@ public SettlementReportTotalMonthlyAmountRowMap(SettlementReportRequestedByActor
                     ChargeType.Tariff => "D03",
                     ChargeType.Fee => "D02",
                     ChargeType.Subscription => "D01",
-                    _ => throw new ArgumentOutOfRangeException(nameof(row.Value.ChargeType)),
+                    _ => throw new ArgumentOutOfRangeException(
+                        nameof(row.Value.ChargeType),
+                        row.Value.ChargeType,
+                        "Value does not contain a enum representation of a ChargeType."),
                 });
 
             Map(r => r.ChargeCode)