Fixed spelling error

Also increased expire time for notification
Moved dispatch of notifications events to status trigger

source/settlement-report/DatabaseMigration/Scripts/202410261405_Add_IsNotificationSent_to_SettlementReport.sql

@@ -1,3 +1,3 @@
 ALTER TABLE [settlementreports].[SettlementReport]
-ADD [IsNotficationSent] [bit] NOT NULL DEFAULT(1); --For all existing records, we will assume that notification has been sent.
+ADD [IsNotificationSent] [bit] NOT NULL DEFAULT(1); --For all existing records, we will assume that notification has been sent.
 GO

source/settlement-report/Orchestration.SettlementReports/Functions/SettlementReports/SettlementReportUpdateStatusTimerTrigger.cs

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+using Energinet.DataHub.Core.Messaging.Communication.Publisher;
 using Energinet.DataHub.SettlementReport.Application.Handlers;
 using Microsoft.Azure.Functions.Worker;
 
@@ -20,10 +21,14 @@ namespace Energinet.DataHub.SettlementReport.Orchestration.SettlementReports.Fun
 internal sealed class SettlementReportUpdateStatusTimerTrigger
 {
     private readonly IListSettlementReportJobsHandler _listSettlementReportJobsHandler;
+    private readonly IPublisher _publisher;
 
-    public SettlementReportUpdateStatusTimerTrigger(IListSettlementReportJobsHandler listSettlementReportJobsHandler)
+    public SettlementReportUpdateStatusTimerTrigger(
+        IListSettlementReportJobsHandler listSettlementReportJobsHandler,
+        IPublisher publisher)
     {
         _listSettlementReportJobsHandler = listSettlementReportJobsHandler;
+        _publisher = publisher;
     }
 
     [Function(nameof(UpdateStatusForSettlementReports))]
@@ -32,7 +37,8 @@ public async Task UpdateStatusForSettlementReports(
         FunctionContext executionContext)
     {
         // We are not interested in the result of the handler, as the handler will update the status of the settlement reports
-        // It will also handling sending Notifications to the expected recipients
+        // It will also handle sending Notifications to the expected recipients
         await _listSettlementReportJobsHandler.HandleAsync().ConfigureAwait(false);
+        await _publisher.PublishAsync(executionContext.CancellationToken).ConfigureAwait(false);
     }
 }

source/settlement-report/SettlementReports.Application/SettlementReports_v2/SettlementReport.cs

@@ -58,7 +58,7 @@ public sealed class SettlementReport
 
     public long? JobId { get; init; }
 
-    public bool IsNotficationSent { get; private set; }
+    public bool IsNotificationSent { get; private set; }
 
     public SettlementReport(
         IClock clock,
@@ -82,7 +82,7 @@ public SettlementReport(
         SplitReportPerGridArea = request.SplitReportPerGridArea;
         IncludeMonthlyAmount = request.IncludeMonthlyAmount;
         GridAreas = JsonSerializer.Serialize(request.Filter.GridAreas);
-        IsNotficationSent = false;
+        IsNotificationSent = false;
     }
 
     public SettlementReport(
@@ -109,7 +109,7 @@ public SettlementReport(
         SplitReportPerGridArea = request.SplitReportPerGridArea;
         IncludeMonthlyAmount = request.IncludeMonthlyAmount;
         GridAreas = JsonSerializer.Serialize(request.Filter.GridAreas);
-        IsNotficationSent = false;
+        IsNotificationSent = false;
     }
 
     // EF Core Constructor.
@@ -139,6 +139,6 @@ public void MarkAsFailed()
 
     public void MarkAsNotificationSent()
     {
-        IsNotficationSent = true;
+        IsNotificationSent = true;
     }
 }

source/settlement-report/SettlementReports.Infrastructure/Notifications/IntegrationEventProvider.cs

@@ -68,7 +68,7 @@ private Task<IntegrationEvent> CreateAsync(Application.SettlementReports_v2.Sett
                 TargetUserId = reportForNotification.UserId.ToString(),
                 RelatedId = reportForNotification.Id.ToString(),
                 OccurredAt = now.ToTimestamp(),
-                ExpiresAt = now.AddHours(23).ToTimestamp(),
+                ExpiresAt = now.AddDays(6).ToTimestamp(),
             });
 
         return Task.FromResult(integrationEvent);

source/settlement-report/SettlementReports.Infrastructure/Persistence/SettlementReportRequest/SettlementReportRepository.cs

@@ -94,7 +94,7 @@ public async Task DeleteAsync(Application.SettlementReports_v2.SettlementReport
     public async Task<IEnumerable<Application.SettlementReports_v2.SettlementReport>> GetNeedsNotificationSentForCompletedAndFailed()
     {
         return await _context.SettlementReports
-            .Where(x => x.IsNotficationSent == false && (x.Status == SettlementReportStatus.Completed || x.Status == SettlementReportStatus.Failed))
+            .Where(x => x.IsNotificationSent == false && (x.Status == SettlementReportStatus.Completed || x.Status == SettlementReportStatus.Failed))
             .OrderBy(x => x.EndedDateTime)
             .ToListAsync()
             .ConfigureAwait(false);