Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Vue): wrapped component's camelCase events not being listened to #921

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

Currently, when using Vue-wrapped components the camelCase events are not listened to.
If we do the following:

const handleEmail = (ev: BqInputCustomEvent<{ value: string | number | string[], el: HTMLBqInputElement }>) => {
  console.log(ev.detail.value as string);
}

<BqInput name="email" type="email" :value="email" @bqChange="handleEmail" />

The bqChange is not listened to and the handleEmail handler is not triggered.

Related Issue

N/A

Documentation

There's a related issue in the @ionic/stencil-ds-output-targets repository:
ionic-team/stencil-ds-output-targets#262 (comment)

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label Mar 8, 2024
@dgonzalezr dgonzalezr self-assigned this Mar 8, 2024
Cata1989
Cata1989 previously approved these changes Mar 8, 2024
Cata1989
Cata1989 previously approved these changes Mar 8, 2024
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit a9f809a into main Mar 8, 2024
5 checks passed
@dgonzalezr dgonzalezr deleted the fix/beeq-vue branch March 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
Status: Released 🚀
Development

Successfully merging this pull request may close these issues.

2 participants