Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(CSS): remove the massive wall of empty CSS properties added by Tailwind CSS #913

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented Mar 6, 2024

Description

The default Tailwind CSS behavior adds a lot of useless empty custom CSS properties.

CleanShot 2024-03-06 at 13 27 25

with these changes, we avoid Tailwind bloating the CSS with all these custom CSS properties.

CleanShot 2024-03-06 at 13 28 02.

Here we're also disabling the usage of rgb/opacity, which also removes a massive block of empty Custom Properties that Tailwind generates.

Related Issue

N/A

Documentation

https://piccalil.li/blog/a-css-project-boilerplate/
https://v2.tailwindcss.com/docs/configuration#variant-order

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Disables rgb/opacity usages, and customize the variants order
@dgonzalezr dgonzalezr added the chore ⚙️ Things related to chore functionalities (types, build, ci/cd, lint, etc.) label Mar 6, 2024
endv-bogdanb
endv-bogdanb previously approved these changes Mar 6, 2024
Cata1989
Cata1989 previously approved these changes Mar 6, 2024
@dgonzalezr dgonzalezr changed the title chore(Tailwind CSS): get rid of the massive wall of custom CSS properties perf(CSS): remove the massive wall of empty CSS properties added by Tailwind CSS Mar 6, 2024
@dgonzalezr dgonzalezr dismissed stale reviews from Cata1989 and endv-bogdanb via 23037f9 March 6, 2024 11:51
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit d21a32c into main Mar 6, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the chore/tailwind-config branch March 6, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ⚙️ Things related to chore functionalities (types, build, ci/cd, lint, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants