-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Icon): replace title
attribute with label
#880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamudeHomsi
requested review from
dgonzalezr and
endv-bogdanb
as code owners
February 27, 2024 16:31
dgonzalezr
reviewed
Feb 27, 2024
dgonzalezr
reviewed
Feb 27, 2024
dgonzalezr
changed the title
feat(icon): Add aria-label to bq-icon
fix(Icon): replace Feb 27, 2024
title
attribute with aria-label
HamudeHomsi
changed the title
fix(Icon): replace
fix(Icon): replace Feb 28, 2024
title
attribute with aria-label
title
attribute with label
dgonzalezr
reviewed
Feb 28, 2024
Quality Gate passedIssues Measures |
dgonzalezr
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
label
attribute to and removetitle
. This will hide the tooltip with the icon name on hover, but still keep the accessibility.