Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icon): replace title attribute with label #880

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

HamudeHomsi
Copy link
Collaborator

@HamudeHomsi HamudeHomsi commented Feb 27, 2024

add label attribute to and remove title. This will hide the tooltip with the icon name on hover, but still keep the accessibility.

@dgonzalezr dgonzalezr changed the title feat(icon): Add aria-label to bq-icon fix(Icon): replace title attribute with aria-label Feb 27, 2024
@HamudeHomsi HamudeHomsi changed the title fix(Icon): replace title attribute with aria-label fix(Icon): replace title attribute with label Feb 28, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit f343653 into main Feb 28, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the feature/bq-icon_aria-label branch February 28, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants