Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toast): toast rendered as visible with open="false" #315

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix(toast): toast rendered as visible with open="false" #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1812bdb
fix(toast): toast rendered as visible with `open="false"`
dgonzalezr Jul 3, 2023
31a6358
test(toast): add e2e tests for `open` attribute
dgonzalezr Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/bee-q/src/components/toast/__tests__/bq-toast.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,42 @@ describe('bq-toast', () => {
expect(element.shadowRoot).not.toBeNull();
});

it('should render as hidden', async () => {
const page = await newE2EPage();
await page.setContent('<bq-toast></bq-toast>');

const element = await page.find('bq-toast');
expect(element).toEqualAttribute('aria-hidden', 'true');
expect(element).toHaveClass('is-hidden');
});

it('should render as hidden with `open="false"`', async () => {
const page = await newE2EPage();
await page.setContent('<bq-toast open="false"></bq-toast>');

const element = await page.find('bq-toast');
expect(element).toEqualAttribute('aria-hidden', 'true');
expect(element).toHaveClass('is-hidden');
});

it('should render as open', async () => {
const page = await newE2EPage();
await page.setContent('<bq-toast open></bq-toast>');

const element = await page.find('bq-toast');
expect(element).not.toEqualAttribute('aria-hidden', 'true');
expect(element).not.toHaveClass('is-hidden');
});

it('should render as open with `open="true"`', async () => {
const page = await newE2EPage();
await page.setContent('<bq-toast open="true"></bq-toast>');

const element = await page.find('bq-toast');
expect(element).not.toEqualAttribute('aria-hidden', 'true');
expect(element).not.toHaveClass('is-hidden');
});

it('should display text', async () => {
const page = await newE2EPage();
await page.setContent('<bq-toast>Text</bq-toast>');
Expand Down
7 changes: 6 additions & 1 deletion packages/bee-q/src/components/toast/bq-toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,12 @@ export class BqToast {

render() {
return (
<Host aria-hidden={!this.open ? 'true' : 'false'} hidden={!this.open ? 'true' : 'false'} role="status">
<Host
class={{ 'is-hidden': !this.open }}
aria-hidden={!this.open ? 'true' : 'false'}
hidden={!this.open ? 'true' : 'false'}
role="status"
>
<output class="bq-toast" part="wrapper">
<div class={{ [`bq-toast--icon ${this.type}`]: true, '!hidden': this.hideIcon }} part="icon">
<slot name="icon">
Expand Down
6 changes: 3 additions & 3 deletions packages/bee-q/src/components/toast/scss/bq-toast.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
@import './bq-toast.variables';

:host {
@apply hidden;
@apply inline-block;
}

:host([open]) {
@apply inline-block;
:host(.is-hidden) {
@apply hidden;
}

.bq-toast {
Expand Down