Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Radio): enable support for form-associated #1353

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR enables support for form-associated custom elements, allowing them to participate in HTML forms:

https://stenciljs.com/docs/forms#using-form-associated-custom-elements
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/attachInternals

To attach the component to a form, users need to do so manually. With this PR, users only need to be aware of setting the component name attribute/property to be linked to the form.

Related Issue

N/A

Documentation

Screenshots (if applicable)

CleanShot.2024-11-29.at.19.13.16.mp4

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

Copy link

sonarqubecloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dgonzalezr dgonzalezr merged commit 674aa6b into main Dec 3, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the feat/radio branch December 3, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🛠 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants