Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Assets Path): set bqSVGBasePath when window and document objects are available #1238

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This pull request ensures that bqSVGBasePath is assigned to the global window object only when both the window and document (including a query to the document object) are accessible on the client side. This adjustment is crucial for enabling SSR as seen in #1216, and it helps avoid errors that occur when the window or document objects are referenced server-side, where they do not exist.

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains label Aug 29, 2024
@dgonzalezr dgonzalezr force-pushed the refactor/assets-path branch from f83dd2b to 5402d5b Compare August 29, 2024 12:42
Copy link

@dgonzalezr dgonzalezr merged commit 3dfb921 into main Aug 29, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the refactor/assets-path branch August 29, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants