Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Notification): set notification portal from the components lifecycle: connectedCallback() #1236

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR shifts the creation of the notification portal container from outside the component into the connectedCallback() lifecycle method. This change is necessary to support SSR #1216 and to prevent errors when calling the window or document object from the server, where they are not available.

Related Issue

N/A

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains label Aug 29, 2024
Copy link

@dgonzalezr dgonzalezr merged commit b633b21 into main Aug 29, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/notification branch August 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants