Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): display value is not shown when initial value is set #1217

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This pull request resolves an issue with the Select component not displaying the selected value when the initial value is set directly. For example, when having something like the following:

<BqSelect
  name="gender"
  placeholder="Select from the list"
  value="Rather not say"
>
  <BqOption value="male">Male</BqOption>
  <BqOption value="female">Female</BqOption>
  <BqOption value="rather not say">Rather not say</BqOption>
</BqSelect>

The component renders with an empty display value, even though the 'Male' option is selected.

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

CleanShot 2024-08-21 at 15 31 31

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label Aug 21, 2024
Copy link

@dgonzalezr dgonzalezr merged commit af7a088 into main Aug 22, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/select branch August 22, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants