Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Input): enable support for form-associated #1211

Merged
merged 3 commits into from
Aug 14, 2024
Merged

feat(Input): enable support for form-associated #1211

merged 3 commits into from
Aug 14, 2024

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented Aug 13, 2024

Description

This PR enables support for form-associated custom elements, allowing them to participate in HTML forms:

Currently, to attach the <bq-input> component to a form users need to do so manually. With this PR, users only need to be aware of setting the component name attribute/property to be linked to the form.

CleanShot.2024-08-13.at.16.30.22.mp4

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

Copy link

Copy link

@lunganC-deko lunganC-deko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🫶

@dgonzalezr dgonzalezr merged commit 6b1c97f into main Aug 14, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the feat/input branch August 14, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🛠 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants