Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): missing @stencil/core dependency for framework targets #1172

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR solves the issue where @stencil/core is missing as a dependency when using any framework output target within BEEQ.

CleanShot 2024-07-25 at 12 31 09@2x

It seems that @stencil/core should be added as a dependency of the core component library (@beeq/core) when using any framework output target.

Details: https://discord.com/channels/520266681499779082/1222546631816118305

CleanShot 2024-07-25 at 12 35 55@2x

Related Issue

N/A

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added bug 🐛 Something isn't working chore ⚙️ Things related to chore functionalities (types, build, ci/cd, lint, etc.) labels Jul 25, 2024
@dgonzalezr dgonzalezr changed the title fix(deps): missing @stencil/core dependency for framework output targets fix(deps): missing @stencil/core dependency for framework targets Jul 25, 2024
@dgonzalezr dgonzalezr force-pushed the fix/stencil-core-dependency branch from ac53775 to ecf8a31 Compare July 25, 2024 10:18
Copy link

@dgonzalezr dgonzalezr merged commit 4aaa073 into main Jul 25, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/stencil-core-dependency branch July 25, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working chore ⚙️ Things related to chore functionalities (types, build, ci/cd, lint, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants