Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Divider): default values to be in sync with Figma design #1160

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR fixes the default values of the BqDivider as per Figma Design.

  • Text alignment will be set to the edge of the component when the value is not middle, meaning that the stroke-basis will default to 0.
  • The stroke-thickness to be 1px.
  • The stroke-color to be stroke-primary.

Dependant components like the Drawer and the Steps that use the divider under the hook have been updated accordingly.

CleanShot.2024-07-23.at.18.11.38.mp4

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label Jul 23, 2024
endv-bogdanb
endv-bogdanb previously approved these changes Jul 24, 2024
Copy link

@dgonzalezr dgonzalezr merged commit 380963d into main Jul 24, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/divider branch July 24, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants