Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Steps): use CSS logical properties instead of physical values #1158

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

This PR refactors the CSS of BqStep and BqStepItem with CSS logical properties, to provide better support for RTL content layout.

CleanShot.2024-07-23.at.10.16.14.mp4

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains label Jul 23, 2024
Copy link

Copy link
Collaborator

@Cata1989 Cata1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dgonzalezr dgonzalezr merged commit a7852b1 into main Jul 23, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the refactor/steps branch July 23, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🧑🏼‍🔧 When something have been changed but the main scope/functionality remains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants