-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Accordion): use CSS logical properties instead of physical values #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cata1989
force-pushed
the
refactor/accordion-logical-properties
branch
from
June 25, 2024 10:20
df2c201
to
4ce51bb
Compare
packages/beeq/src/components/accordion-group/scss/bq-accordion-group.scss
Outdated
Show resolved
Hide resolved
packages/beeq/src/components/accordion-group/scss/bq-accordion-group.scss
Outdated
Show resolved
Hide resolved
Cata1989
force-pushed
the
refactor/accordion-logical-properties
branch
from
June 25, 2024 11:11
374ec5f
to
269c65e
Compare
Cata1989
force-pushed
the
refactor/accordion-logical-properties
branch
from
July 8, 2024 14:52
269c65e
to
fbf956e
Compare
dgonzalezr
force-pushed
the
refactor/accordion-logical-properties
branch
from
July 17, 2024 07:48
fbf956e
to
6309cc4
Compare
Allow disabling completely open/close animation
dgonzalezr
added
the
refactor 🧑🏼🔧
When something have been changed but the main scope/functionality remains
label
Jul 17, 2024
dgonzalezr
previously approved these changes
Jul 17, 2024
dgonzalezr
previously approved these changes
Jul 17, 2024
endv-bogdanb
previously approved these changes
Jul 18, 2024
Quality Gate passedIssues Measures |
dgonzalezr
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to modernize the CSS by incorporating logical properties for improved adaptability and support for RTL content direction and vertical layout.
We have implemented CSS animation for the summary HTML element using block-size and calc-size (still in draft). If calc-size is supported:
the open/close animation will be handled via CSS instead of JavaScript. This enhances considerably the way the animation behaves on a vertical layout.
If calc-size() is not yet supported by the browser (feature flag is not enabled) animations will be handled via JavaScript, and, if there's a need for a vertical layout, we have added the possibility to disable all animation so the component works as expected, without shifting when opening or closing.
Related Issue
N/A
Documentation
Screenshots (if applicable)
CleanShot.2024-07-17.at.16.40.23.mp4
Checklist
Additional Notes