Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Empty State): use CSS logical properties instead of physical values #1112

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Cata1989
Copy link
Collaborator

@Cata1989 Cata1989 commented Jun 17, 2024

Description

The goal of this PR is to modernize the CSS by incorporating logical properties for improved adaptability and support for different writing modes.

Screenshot 2024-06-17 at 15 12 58

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@Cata1989 Cata1989 force-pushed the refactor/empty-state-logical-properties branch from 947adb1 to cfb188e Compare June 21, 2024 06:13
Copy link

@dgonzalezr dgonzalezr merged commit 9494ecb into main Jun 21, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the refactor/empty-state-logical-properties branch June 21, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants