Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Alert): use CSS logical properties instead of physical values #1094

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

Cata1989
Copy link
Collaborator

@Cata1989 Cata1989 commented Jun 10, 2024

Description

The goal of this PR is to modernize the CSS by incorporating logical properties for improved adaptability and support for different writing modes.

Screenshot 2024-06-17 at 11 38 13

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@Cata1989 Cata1989 changed the title perf(Alert): update to logical CSS properties refactor(Alert): update to logical CSS properties Jun 10, 2024
@Cata1989 Cata1989 changed the title refactor(Alert): update to logical CSS properties refactor(Alert): use CSS logical properties instead of physical values Jun 10, 2024
@Cata1989 Cata1989 force-pushed the perf/alert-logical-properties branch from d484f10 to f3c42e4 Compare June 11, 2024 08:08
@Cata1989 Cata1989 marked this pull request as ready for review June 11, 2024 08:43
@Cata1989 Cata1989 force-pushed the perf/alert-logical-properties branch 2 times, most recently from 4a35182 to 2dc9973 Compare June 17, 2024 08:37
@dgonzalezr dgonzalezr force-pushed the perf/alert-logical-properties branch from f55b026 to 4419d82 Compare June 20, 2024 15:48
Copy link

@dgonzalezr dgonzalezr merged commit 7839159 into main Jun 20, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the perf/alert-logical-properties branch June 20, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants